a8m / a8m/angular-filter

filterBy on boolean is not working

Open
#208 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.9k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

Filtering on a boolean property has no effect at all.
_Example_: `$filter('filterBy')(collection, ['property'], true)`

Looking at the [source](https://github.com/a8m/angular-filter/blob/master/src/_filter/collection/filter-by.js) we can see that only string and number are allowed.
_Line 14_: `search = (isString(search) || isNumber(search)) ? String(search).toLowerCase() : undefined;`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.