a2ui-project / a2ui-project/a2ui

Consider removing the `variant` property on `Text` in favor of just using Markdown

Ouverte
#999 2 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
P2 sprint ready type: feature/enhancement
Langage dominant
TypeScript
Étoiles
16.4k
Forks
1.3k
Merge moyen
2 j 13 h
PR mergées (30 j)
134

Description

Currently, Markdown allows you to specify H1, H2, H3 etc through `# Heading 1` etc, but we also redundantly provide a `variant` parameter for this.

How about we remove this redundancy? It's awkward to implement also. What if we have a `h1` variant Text, with `#### Subtitle` in it? Which level is that heading?

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Look for the Text component definition, likely in a file like Text.tsx or a components directory. Identify where the variant property is used and how it interacts with Markdown parsing. Check for any tests related to Text or heading rendering to understand the expected behavior. The goal is to remove the variant property while ensuring Markdown headings (#, ##, etc.) are correctly rendered.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
markdown, typescript
Domaine
frontend
Type d'issue
Refactorisation
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
55/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.