a2ui-project / a2ui-project/a2ui

ci: Add explicit `types` to prevent `@types/node` leakage.

Ouverte Adaptée aux débutants
#2,059 0 commentaires 0 réactions 1 personne assignée Réclamée par @ditman Voir sur GitHub
CI/CD P2
Langage dominant
TypeScript
Étoiles
16.4k
Forks
1.3k
Merge moyen
2 j 13 h
PR mergées (30 j)
134

Description

In our monorepo, omitting the `"types"` property in a project's `tsconfig.json` causes TypeScript to automatically discover and include all type packages from `node_modules/@types`, including root-level packages like `@types/node` and `@types/jest`.

(See #1515)

For browser-only frontend projects targeting DOM (`"lib": ["DOM", "ESNext"]`), auto-including `@types/node` introduces global type namespace pollution and type collisions (for example, `setTimeout` returning `NodeJS.Timeout` instead of `number`, or conflicting `Console` and `Event` interfaces).

Most core libraries and Angular projects in the repository already specify `"types": []` or explicit type arrays. We should update the remaining browser frontend shells and community sample projects to prevent global type leakage.

#### Proposed changes

Add `"types": []` (or `"types": ["vite/client"]` for Vite applications) to `compilerOptions` in the following files:

- [ ] `samples/client/react/shell/tsconfig.json` (add `"types": ["vite/client"]`)
- [ ] `samples/community/client/lit/mcp-apps-in-a2ui-sample/tsconfig.json` (add `"types": []`)
- [ ] `samples/community/client/lit/personalized_learning/tsconfig.json` (add `"types": []`)
- [ ] `samples/community/mcp/a2ui-over-mcp-recipe/client/tsconfig.json` (add `"types": []`)

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

The issue lists four specific tsconfig.json files to update. Start by locating each file in the repository. For the Vite application, add `"types": ["vite/client"]`; for the others, add `"types": []`. Verify the change by checking the TypeScript compiler options and ensuring no type errors appear in the respective projects.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript, vite
Domaine
build-system, frontend
Type d'issue
Bug
Difficulté
1/5
Temps estimé
Moins d'une heure
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
75/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.