a2ui-project / a2ui-project/a2ui

Improve validateCatalogItemExamples to make sure the examples can be parsed.

Đang mở
#1,834 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
component: genui P3
Ngôn ngữ chính
TypeScript
Star
16.4k
Fork
1.3k
Merge trung bình
2 ngày 13 giờ
Pull request đã merge (30 ngày)
134

Mô tả

_↴ Ported from [flutter/genui#449](https://github.com/flutter/genui/issues/449) — originally opened by [polina-c](https://github.com/polina-c) on 2025-10-26._
_Original labels: P3, c: ebb_

---

This is follow up for https://github.com/flutter/genui/pull/429

I was updating catalog items examples in my app to match new GenUi schema.

I updated the catalog items examples to look similar to those in genui and to pass this test:

```
for (final item in namedCatalog.catalog.items) {
test('CatalogItem ${item.name} examples are valid', () async {
if (item.name != 'code') return;
final errors = await validateCatalogItemExamples(
item,
namedCatalog.catalog,
);
expect(errors, isEmpty, reason: errors.join('\n'));
});
}
```

Tests passed, but the rendering failed:

Image

```
The following ArgumentError was thrown building AppCatalogView:
Invalid argument(s): Component.fromJson: component property is null

...

new Component.fromJson (package:flutter_genui/src/model/ui_models.dart:141:7)
```

After investigation I found i did not replace 'widget' with 'component' in one of items.

`validateCatalogItemExamples` should be updated to handle such errors, to make sure that DebugCatalogView can parse the items.

---

### 2 comment(s) from the original issue

**[polina-c](https://github.com/polina-c)** commented on 2025-10-26:

@jacobsimionato

---

**[jacobsimionato](https://github.com/jacobsimionato)** commented on 2025-11-03:

Removing from M1, because this isn't specific to that project.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.