a2ui-project / a2ui-project/a2ui

DateTimeInput date parsing is not great.

Aperta
#1,673 3 commenti 0 reazioni 1 assegnatario Rivendicata da @Varun-S10 Vedi su GitHub
component: angular renderer component: lit renderer component: react renderer P2 type: feature/enhancement
Lingua principale
TypeScript
Stelle
16.4k
Fork
1.3k
Merge medio
2g 13h
PR unite (30g)
134

Descrizione

The Date parsing on the DateTimeInput is not super flexible and because of how browsers work, may "clear" values when rendering them.

Our basic catalog implementation should be a little bit more [robust](https://github.com/a2ui-project/a2ui/blob/main/renderers/angular/src/v0_9/catalog/basic/date-time-input.component.ts#L108-L118) [than](https://github.com/a2ui-project/a2ui/blob/main/renderers/lit/src/v0_9/catalogs/basic/components/DateTimeInput.ts#L31-L52) [this](https://github.com/a2ui-project/a2ui/blob/main/renderers/react/src/v0_9/catalog/basic/components/DateTimeInput.tsx#L22-L40).

There's some cool libraries that we could use (like `any-date-parser` backed by Intl?), but as an MVP, we should guarantee that we can parse exactly what the spec says (and add tests to prove it)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.