a2aproject / a2aproject/a2a-samples

Bug in pure mcp example (missing tool name)

Aperta
#438 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Jupyter Notebook
Stelle
1.8k
Fork
751
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### What happened?

https://github.com/a2aproject/a2a-samples/blob/f140c6d5bc90297f448fdf73ab4b32c16f7cf60c/samples/python/agents/a2a-mcp-without-framework/src/no_llm_framework/server/agent.py#L153

but in jinja

https://github.com/a2aproject/a2a-samples/blob/f140c6d5bc90297f448fdf73ab4b32c16f7cf60c/samples/python/agents/a2a-mcp-without-framework/src/no_llm_framework/server/called_tools_history.jinja#L2

In jinja, should use "tool.tool" instead to avoid missing tool name in history? (or agent.py should use "name" as key?)

### Relevant log output

```shell
After writting the rendered template, currently the prompt looks like the following

...
Previous tools have been called.
- Tool:
- Arguments: {...
```

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.