a2aproject / a2aproject/a2a-samples

langgraph Stream example is wrong

Open
#309 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
1.8k
Forks
751
PR merge metrics
No merged PRs in 30d

Description

### What happened?

Hi team,

Bug: stream does not work without async for – should use astream for async iteration

Code:
samples/python/agents/langgraph/app/agent.py

I encountered an issue while using the `stream` function in an async context. Here's the original code I used:

```python
async def stream(self, query, context_id) -> AsyncIterable[dict[str, Any]]:
inputs = {'messages': [('user', query)]}
config = {'configurable': {'thread_id': context_id}}

for item in self.graph.stream(inputs, config, stream_mode='values'):
message = item['messages'][-1]
if (
isinstance(message, AIMessage)
and message.tool_calls
and len(message.tool_calls) > 0
):
...
```

However, this **does not stream the response** as expected. It only works properly when I change the line to:

```python
async for item in self.graph.astream(inputs, config, stream_mode='values'):
```

It looks like `graph.stream` returns a synchronous iterator, while `graph.astream` is the correct async generator required for streaming in async functions.

For a complete test and reproduction case, please refer to my repo:
👉 [https://github.com/johnson7788/LangGraphA2A](https://github.com/johnson7788/LangGraphA2A)

Hope this helps improve the documentation or implementation!

Thanks!

### Relevant log output

```shell

```

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.