a2aproject / a2aproject/a2a-python

[Feat]: passing call context to unauthenticated card modifier

Offen
#657 7 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @ishymko Auf GitHub ansehen
component: core
Vorherrschende Sprache
Python
Sterne
2.1k
Forks
496
Ø Merge
4 T. 17 Std.
Gemergte PRs (30 T.)
12

Beschreibung

### Is your feature request related to a problem? Please describe.

We are wondering if support can be added for passing the call context to the regular agent card modifier, just as it is for the extended card modifier.

### Describe the solution you'd like

Agent card modifiers should be given a second parameter for the call context, matching the signature of extended agent card modifiers.

### Describe alternatives you've considered

We can construct our own Application and Adapter classes to override the get agent card endpoint handling, but this is cumbersome and hard to maintain.

### Additional context

I guess we're also wondering if this is intentional - i.e. if agent cards should not depend on anything from the call context. In our case, we want to use part of the request URL (which is dynamic) as part of the `url` field in the response. Also, if we work to add support for this (like in #647), do we have to make the change backwards compatible and support modifiers that don't take in the call context (i.e. only have one parameter for the agent card to be modified)? I think anything goes as long as we're on the 0.X.Y versions (i.e. anything below 1.0), but just want to make sure.

As with #647 I am more than willing to lead development on this.

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.