a2aproject / a2aproject/a2a-js

[Clarification]: DefaultPushNotificationSender does not set the a2a-version header on outgoing push notifications

Open Beginner friendly
#647 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
613
Forks
169
Avg merge
1d 6h
Merged PRs (30d)
21

Description

Hi, thanks for the great work on the SDK.

When using DefaultPushNotificationSender, outgoing push notifications do not include the a2a-version header. This applies both for v1.0 and when using the legacyCompat serializer with v0.3. The receiver has no way to know which protocol version the body conforms to without inspecting the body itself.

Contributor guide

Open the contributing guide

Research direction

Look for the DefaultPushNotificationSender class in the codebase, likely in a file like src/senders/defaultPushNotificationSender.ts or similar. Examine the method that sends push notifications to see how headers are set. The fix is to add the 'a2a-version' header based on the protocol version being used. Check existing tests for push notifications to understand the expected behavior and add a test for the new header.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.