a2aproject / a2aproject/a2a-java

[Feat]: Simplification of the client API?

Abierto
#517 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Java
Estrellas
490
Forks
172
Merge medio
1 d 6 h
PR fusionados (30 d)
55

Descripción

### Is your feature request related to a problem? Please describe.

The `client` API is a thin wrapper around the domain objects in the `spec` module.

I wonder if we could not make the API a bit simpler while retaining all the capabilities it exposes.

### Describe the solution you'd like

For example, a lot of calls wrap their parameters in `XXXParams` object:

```
public Task cancelTask(TaskIdParams request)
```

but TaskIdParams is composed of a `taskId` and a `metadata` map.
Could the call simply be:

```
public Task cancelTask(String taskId, Map metadata) {
return clientTransport.cancelTask(new TaskIdParams(taskId, metadata), request, context);
}
```

and a default method:

```
public default Task cancelTask(String taskId) {
return cancelTask(taskId, emptyMap();
}
```

This way, the `TaskIdParams` does not leak to the `Client` API (making it bigger than it needs to be.

The API is already to that for its `sendMessage` methods that hides the internal `MessageSendParams`.
This is a pattern that should be applied to other methods as well

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.