a2aproject / a2aproject/a2a-dotnet

Consider adding support to streaming to OnMessageReceived in TaskManager

Abierto
#159 4 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C#
Estrellas
262
Forks
64
Merge medio
5 d 2 h
PR fusionados (30 d)
31

Descripción

The issue comes from the fact that the SendMessageStreamingAsync method in TaskManager checks for OnMessageReceived, and if it is found, there is no way to support streaming.

https://github.com/a2aproject/a2a-dotnet/blob/5bee984151b32a9e714781301bedeaaa517a18ba/src/A2A/Server/TaskManager.cs#L244

Since receiving messages is one of the most common actions to override, this prevents people from either streaming or being able to receive messages, just so streaming can work.

Suggestions:

1.- Make the streaming be bases on the UpdateStatusAsync method. streaming should subscribe to events from the UpdateStatusAsync
2.- Add an OnMessageReceivedStreaming method that returns an IAsyncEnumerable.
3.- Add the TaskUpdateEventEnumerator object to the signature of OnMessageReceived, so that events can be pumped out as they are processed.

Pros & Cons

For #1
Pro: No major signature changes, just after creating the AgentTask imedeatly subscribe to it and pass along the enumerator.

For #2
pro: The implementation is semantically good
Con: The implementore will have to implement two methods to receive messages

For #3
Pro: The implementation is straight forward. Semantically it might be ok, not sure. i think i should as the non-streaminmg processing should be able to push notifications.

#1 Is the one i would prefer as it would allow me to use the UpdateStatusAsync naturally.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Examine the TaskManager.cs file, specifically the SendMessageStreamingAsync method around line 244 and the OnMessageReceived delegate. Understand the existing UpdateStatusAsync method and the A2AEvent type. The goal is to design a change that allows streaming without breaking existing overrides. Start by reviewing the three proposed solutions and their implications on the codebase.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
csharp
Área
api, backend
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.