Add CMAKE option to control building/installing static libraries
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cmake
- Domain
- build-system
Research direction
Start by locating the CMake files that call add_library() with SHARED or STATIC and the corresponding installation rules. Review the BUILD_SHARED_LIBS and proposed XRT_INSTALL_STATIC_LIBS approaches, then verify that the selected option controls whether static libraries are installed without changing the intended shared-library behavior.
Written by the indexing model from the issue text.
Description
Currently, XRT has several libraries that it builds both shared and static and it seems in general to always explicitly specify either SHARED or STATIC when calling add_library() in cmake files.
For building XRT as a conda package, the community generally avoids providing static libraries for the reasons outlined in https://github.com/conda-forge/cfep/blob/main/cfep-18.md.
Please add a cmake option that can be used to disable installing static libraries. If XRT only cares to deliver STATIC or SHARED, you could switch to using the standard BUILD_SHARED_LIBS cmake flag. But, if you want to keep delivering both, you will need to create your own XRT_INSTALL_STATIC_LIBS option.
- Dominant language
- C++
- Stars
- 686
- Forks
- 549
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 70
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Xilinx/XRT
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 70/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·