WeblateOrg / WeblateOrg/weblate

Refactor placeholders check to use format checks base

Open
#8,416 0 comments 0 reactions 0 assignees View on GitHub
enhancement Waiting for: Demand
Dominant language
Python
Stars
6.1k
Forks
1.4k
Avg merge
9h 53m
Merged PRs (30d)
395

Description

### Describe the problem

The logic in both checks is basically same, and it also shares logic for plurals since 883b13a61a45e3274f4ba0845ce48893e4d68471 (see #8382).

### Describe the solution you'd like

Reuse `BaseFormatCheck` logic in `PlaceholderCheck` class.

### Describe alternatives you've considered

Currently, the code is more or less copied.

### Screenshots

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.