WeblateOrg / WeblateOrg/weblate

Updated intermediate language resulting in unchanged source requires to re-approve target languages

Open
#7,807 0 comments 1 reaction 0 assignees View on GitHub
enhancement Waiting for: Demand
Dominant language
Python
Stars
6.1k
Forks
1.4k
Avg merge
9h 53m
Merged PRs (30d)
395

Description

### Describe the issue

In our set-up we are majorly using the pattern to first receive a kind of developer english as `Intermediate language` which then first is polished / harmonized into a proper English being the `source` for succeeding translations.

Quite often, developers decide to merge back the polished `source` into their `Intermediate language`. Again this updated `Intermediate language` rises a *source-change* event where the belonging strings in the `source` are set back to *needs editing*, upon which the terminology owners for the proper English (`source`) are required to check and re-approve again. This is all fine.

But at the same time also the target translations are set back from *approved* to *waiting for review*, what might also be fine, if there is really a source change. With the pattern descirbed above, mostly the `source` is just approved again, means set from *needs editing* to *approved* without any changes:
- no key change
- no value change

Still the target translations are kept to *waiting for review* after the `source's` re-approvel (without changes). This creates continuously a lot of effort for translators in any languages to simply go through their translations again and re-approve again without any changes >> overhead, no value.

### I already tried

- [X] I've read and searched [the documentation](https://docs.weblate.org/).
- [X] I've searched for similar issues in this repository.

### Steps to reproduce the behavior

1. Configure a component with intermediate language
2. Derive a `source`, e.g. English and apply slight changes due to terminology harmonization
3. Derive one `target` language
4. Backmerge the `source` to `intermediate language`
5. Observe:
- `source` is set back to needs editing
- `target` is set back to waiting for reviw
6. simply re-approve `source` without changes
7. Observe: `target` is still kept to *waiting for review*

### Expected behavior

After step 6. above (re-approve `source`) I would expect the `target(s)` to keep their former approved state, as well.

### Screenshots

_No response_

### Exception traceback

_No response_

### How do you run Weblate?

Docker container

### Weblate versions

_No response_

### Weblate deploy checks

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.