WeblateOrg / WeblateOrg/weblate

Comments are not properly handled in case of XWiki format translations

Open
#5,897 1 comment 0 reactions 1 assignee Claimed by @surli View on GitHub
Waiting for: Implementation
Dominant language
Python
Stars
6.1k
Forks
1.4k
Avg merge
9h 53m
Merged PRs (30d)
395

Description

**Describe the issue**

Translation key comments are not properly updated when the comment changed on the source file. We saw the problem when moving a key, which led it for not having the comment anymore: apparently all translation keys keeps displaying the comment attached to it, where they should not.
We probably need to always sync the translation comment to the source comment in XWiki format.

**To Reproduce the issue**

Steps to reproduce the behavior:

1. Create a source translation with a comment in XWiki Java Properties format
2. Translate it in several languages
3. Remove the comment or update it in source translation
4. See that translation still have the comments: if the translation is edited, the comment still appear on the output file

**Expected behavior**

The comment should always be updated from the source translation comment.

**Additional context**

See the following commit that show the issue: https://github.com/xwiki/xwiki-platform/pull/1603#discussion_r617363675

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.