More accurate x86 flag writes tracking now that we have the parity flag

Open
#8,340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start in arch/x86/il.cpp around the XOR handling at line 4560, then read the linked pull-request review for the parity-flag context. Scan the x86 lifting code for other broad flag-write markers that can be narrowed. Done means affected instructions track only the flags they actually write, including parity where applicable.

Written by the indexing model from the issue text.

Description

Now that we have proper handling of the parity flag, we should scan the x86 lifting and find those instructions whose flag writes can be made more precise. For example, for XOR, https://github.com/Vector35/binaryninja-api/blob/a09ee8d47d6bb923a8ad6eccea9980dcf8bc35fe/arch/x86/il.cpp#L4560, we use IL_FLAGWRITE_ALL which is too broad.

More details: https://github.com/Vector35/binaryninja/pull/1680#pullrequestreview-4745933861

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.