Missing COFF relocation

Open
#7,982 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
50/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start in arch/x86/arch_x86.cpp around lines 4600-4777 and reproduce the issue by opening thunder rush points valuably, inspecting 0x4f062d, and querying bv.relocations_at(0x4f062d + 1)[0]. Trace how the COFF relocation for _invalid_parameter_noinfo_noreturn is handled; done means the relocation is filled in rather than leaving the call zeroed out.

Written by the indexing model from the issue text.

Description

Effort: Low Impact: Medium
  1. Open thunder rush points valuably
  2. Go to 0x4f062d
  3. Observe zeroed out call to _invalid_parameter_noinfo_noreturn
  4. Relocation information:
>>> bv.relocations_at(0x4f062d + 1)[0]
<Relocation: "_invalid_parameter_noinfo_noreturn" @ 0x60fd00>

Putting this as a bug because IIRC the relocations should be filled in for COFF.

https://github.com/Vector35/binaryninja-api/blob/3eda43f185a0411538745a99e251122e6a9192e0/arch/x86/arch_x86.cpp#L4600-L4777

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.