Vector35 / Vector35/binaryninja-api

Reset `analysis.workflows.functionWorkflow` to `core.function.metaAnalysis` if set to `core.function.objectiveC`

Aperta
#7,718 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Core: Workflow Effort: Trivial Impact: Low
Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Descrizione

Version and Platform (required):

  • Binary Ninja Version: 5.3.8713-dev Ultimate, a40c2e7b
  • OS: macos
  • OS Version: 26.1.0
  • CPU Architecture: arm64

Bug Description:
If a user explicitly set analysis.workflows.functionWorkflow to core.function.objectiveC in Binary Ninja 5.1 or earlier, they'll get some surprising / broken behavior when opening binaries in 5.2 or newer. core.function.objectiveC no longer exists, and instead the Objective-C activities are registered on the meta workflow.

Steps To Reproduce:
Untested, but presumably:

  1. Set analysis.workflows.functionWorkflow to core.function.objectiveC (or some other workflow that does not exist).
  2. Open a binary.

Expected Behavior:
Something sensible.

For core.function.objectiveC we should reset the setting to the default value of core.function.metaAnalysis. The Objective-C workflow was removed in 5.2.

For other values that do not correspond to a workflow that is registered we may want to leave the setting value as-is, log a warning or error, but then use core.function.metaAnalysis anyway. This would handle the case where a named workflow is registered by a plug-in that is no longer available, perhaps due to needing to rebuild due to an ABI bump or due to launching with user plug-ins disabled.

Actual Behavior:
Many thousands of errors, and no functions in linear view.

Additional Information:
Originally reported by a user on Slack.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Start by locating the handling of analysis.workflows.functionWorkflow and the registry of registered workflows. Reproduce the legacy core.function.objectiveC setting if possible, then verify that it falls back to core.function.metaAnalysis without generating errors or leaving functions unavailable; also determine the intended behavior for other unregistered workflow names.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
cpp
Ambito
reverse-engineering
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.