Vector35 / Vector35/binaryninja-api
Reset `analysis.workflows.functionWorkflow` to `core.function.metaAnalysis` if set to `core.function.objectiveC`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: 5.3.8713-dev Ultimate, a40c2e7b
- OS: macos
- OS Version: 26.1.0
- CPU Architecture: arm64
Bug Description:
If a user explicitly set analysis.workflows.functionWorkflow to core.function.objectiveC in Binary Ninja 5.1 or earlier, they'll get some surprising / broken behavior when opening binaries in 5.2 or newer. core.function.objectiveC no longer exists, and instead the Objective-C activities are registered on the meta workflow.
Steps To Reproduce:
Untested, but presumably:
- Set
analysis.workflows.functionWorkflowtocore.function.objectiveC(or some other workflow that does not exist). - Open a binary.
Expected Behavior:
Something sensible.
For core.function.objectiveC we should reset the setting to the default value of core.function.metaAnalysis. The Objective-C workflow was removed in 5.2.
For other values that do not correspond to a workflow that is registered we may want to leave the setting value as-is, log a warning or error, but then use core.function.metaAnalysis anyway. This would handle the case where a named workflow is registered by a plug-in that is no longer available, perhaps due to needing to rebuild due to an ABI bump or due to launching with user plug-ins disabled.
Actual Behavior:
Many thousands of errors, and no functions in linear view.
Additional Information:
Originally reported by a user on Slack.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the handling of analysis.workflows.functionWorkflow and the registry of registered workflows. Reproduce the legacy core.function.objectiveC setting if possible, then verify that it falls back to core.function.metaAnalysis without generating errors or leaving functions unavailable; also determine the intended behavior for other unregistered workflow names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100