Clickable address in assertion (user defined pvs hint) for ConstantPointerValue

Open
#7,259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start by tracing how IL_ASSERT handles ConstantPointerValue and assigns InstructionTextTokenType.PossibleValueToken. Check the related token-generation entry point and existing address-token behavior; done means the user-hinted address, such as 0x789b41, is rendered as a clickable address.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Low

What is the feature you'd like to have?
It would be nice to be able to click on address that is hinted by user in IL_ASSERT. For example on provided screenshot - 0x789b41.

Image

Currently the token with constant has type InstructionTextTokenType.PossibleValueToken which AFAIK not clickable, mb it should be InstructionTextTokenType.PossibleAddressToken instead?

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.