Vector35 / Vector35/binaryninja-api

HLIL shows deeply nested if statements with duplicated bodies that should be a single `if (a || b || c || d || e || f)`

Aperta
#6,537 0 commenti 2 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Component: Core Core: HLIL Impact: Medium
Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Descrizione

Version and Platform (required):

  • Binary Ninja Version: 5.0.7116-dev (78683157)
  • OS: macOS 15.3.2
  • CPU Architecture: arm64e

Bug Description:

Image Image Image

Steps To Reproduce:

  1. Open dyld shared cache from macOS 15.3.2 and load ImageIO.framework.
  2. Go to ___IIOIsOOPEnabled_block_invoke and look at the HLIL in linear view.

Expected Behavior:
Readable HLIL without the duplication. With the current HLIL it's hard to tell whether the bodies of the if statements are identical without looking closely at each of them.

In MLIL you can see each of the ~20 basic blocks in this part of the function look like so:

  22 @ 18bdd2a9c  CFStringRef x0_5 = x19
  23 @ 18bdd2aa4  x0_4 = j__CFStringCompare(theString1: x0_5, theString2: &cfstr_com.apple.MessagesAirlockService, compareOptions: 0)
  24 @ 18bdd2aa8  if (x0_4 == 0) then 37 @ 0x18bdd2cb8 else 40 @ 0x18bdd2ab4

They all have a common target when the result of CFStringCompare is 0. When non-zero, they fall through to the next comparison in the sequence. This should be recognized as a single if with many conditions or'd together:

if (!CFStringCompare(…)
    || !CFStringCompare(…)
    || !CFStringCompare(…)
    || …)
    x20_1 = "disabled"
    x8_1 = "always exempt process"

Binary:
/System/Cryptexes/OS/System/Library/dyld/dyld_shared_cache_arm64e on macOS 15.3.2.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Reproduce the issue by opening the specified dyld shared cache, loading ImageIO.framework, and inspecting ___IIOIsOOPEnabled_block_invoke in HLIL linear view. Compare the roughly 20 MLIL basic blocks with the generated HLIL. Done means the repeated comparisons are represented as one conditional with ORed conditions and the shared body is shown once.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
cpp
Ambito
reverse-engineering
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.