Redesign/Reconcile the BinaryDataNotifications for the MemoryMap System
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- api, reverse-engineering
Research direction
Start by tracing MemoryMap::AddDataMemoryRegion and the BinaryDataNotification callbacks, especially OnSegmentUpdated and OnSegmentAdded. Reproduce the segment addition behavior in the DSC-style binary view described in the report, then verify that the added segment triggers OnSegmentAdded and is passed as the callback argument.
Written by the indexing model from the issue text.
Description
Version and Platform (required):
- Binary Ninja Version: 4.3.7047-dev (0672492d)
- OS: macOS
- OS Version: 15.2
- CPU Architecture: M1
Bug Description:
When calling MemoryMap::AddDataMemoryRegion to add segments to a binary view (like the DSC plugin does), it only triggers the binary view notification void BinaryDataNotification::OnSegmentUpdated(BinaryView* data, Segment* segment) and segment is always the first segment in the binary. So for the DSC view this is the DSC header segment from 0x180000000 to 0x180000208.
Expected Behavior:
The OnSegmentAdded callback should be called when adding segments using MemoryMap::AddDataMemoryRegion and the correct segment (the one that was just added) should be passed to the callback.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Vector35/binaryninja-api
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Vector35/binaryninja-api#8540 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Vector35/binaryninja-api#8516 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Vector35/binaryninja-api#8503 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Vector35/binaryninja-api#8446 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Vector35/binaryninja-api#8444 ·
All issues in Vector35/binaryninja-api
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·