Make merge conflicts occur on core objects rather than JSON blobs

Open
#5,720 0 comments 0 reactions 1 assignee View on GitHub

@CouleeApps is already working on this.

Since Jul 11, 2024.

Assessment

This issue has not been assessed yet.

Description

Component: Merge Conflict Edition: Ultimate Effort: High Impact: High

Right now, we perform merge conflicts on JSON blobs pulled directly out of the snapshot we're merging from. This has a whole host of limitations associated with it, including:

  • #5721
  • #5722
  • #5723
  • #5724

We should instead make merge conflicts occur on core objects (falling back to JSON when necessary) so that our merge conflicts can be improved.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.