Find All / Search preview should be able to fetch the nearest instruction

Open
#5,038 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp

Research direction

No files, tests, or entry points are named. Start by locating the Find All/Search preview and disassembly behavior described here, then determine how a result inside an instruction can resolve to the nearest instruction and where a before/after option belongs. Done means the preview shows the requested nearest instruction behavior without requiring each result to be opened.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Low

What is the feature you'd like to have?
Currently, the search box is optimized for finding rop gadgets. If you search into the middle of an instruction, it will disassemble the bytes it found rather than the nearest instruction in the disassembly. It would be nice if there was a checkbox or option in the right click context menu to "Show nearest instruction". Maybe to be able to go nearest before or after (I would prefer before).

Is your feature request related to a problem?
When searching to see what a chunk of bytes is hitting in a binary (e.g. from a malware signature) the disassembly in the preview does not reflect the actual instructions. Instead you must click into each result.

Thank you!

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.