DataVariable type references not properly updated after undefining child types

Open
#5,031 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
desktop, reverse-engineering

Research direction

Reproduce the crash with the attached ls.zip by creating a structure array, then undefining struct_1 from the types sidebar. Start at the structure and DataVariable type-reference handling used by the undefine action; done means undefining the child type no longer crashes Binary Ninja and the remaining references are updated correctly.

Written by the indexing model from the issue text.

Description

Component: Core Effort: Trivial Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 4.0.4836-dev, df4290fd
  • OS: macos
  • OS Version: 14.3
  • CPU Architecture: arm64

Steps To Reproduce:

  1. Open the attached binary
  2. Navigate to adress 100007a53
  3. Select two lines and create a structure using the S shortcut to generate a dummy structure named struct_1
  4. Convert that structure to a structure array with two items
    You should get something like:
  1. Open types sidebar and undefine struct_1
  2. Observe the crash

Additional Information:
ls.zip

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.