Vector35 / Vector35/binaryninja-api
Plugin Callbacks should pass Function *
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
For the plugin RegisterForAddress and RegisterForRange callbacks, they should pass the Function instance in addition to the address. Since Binja supports overlapping disassembly and overlapping functions, an address in isolation means nothing without its Function context.
These should pass the Function as well:
https://github.com/Vector35/binaryninja-api/blob/master/plugin.cpp#L75
https://github.com/Vector35/binaryninja-api/blob/master/plugin.cpp#L171
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in plugin.cpp at the RegisterForAddress callback around line 75 and the RegisterForRange callback around line 171. Trace the callback signatures and their uses, then update them so each receives the relevant Function alongside the address. Done means both plugin callbacks expose the Function context needed for overlapping disassembly and functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100