Override call type dialog should show current call type at first time open

Open
#4,833 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Reproduce the issue by opening the call-type override dialog for a call whose inferred signature is visible in linear view. Trace the dialog's initial value and compare it with the call type Binary Ninja has already detected. Done means the first-open value reflects the detected signature instead of the generic void calltarget() placeholder.

Written by the indexing model from the issue text.

Description

Component: Core Effort: Low Impact: Low UI: Dialogs

Version and Platform (required):

  • Binary Ninja Version: 3.6.4719-dev, dec72a07
  • OS: macos
  • OS Version: 14.2
  • CPU Architecture: arm64

Bug Description:

Let's say there is a function call in linear view like this:

job->callback(job, config, job->field_10)

When I try to override call type for this call, dialog show me this as default call type: void calltarget(). But obviously there is different call type detected by BN. Instead of void calltarget(), BN should show me current call type which is something like this: void (* callback)(struct my_job*, struct config*, int64_t).

If BN do so and it predicts it correctly, I can easily copy that and set structure member type to that.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.