PE view creates functions at data variable exports

Open
#4,053 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Reproduce the issue using the binary referenced by Vector35/binaryninja-api#3709 and inspect address 0x100162e8. Start with the PE loader's export handling, especially its treatment of exports in executable segments. Done means data variable exports no longer produce erroneous functions while real functions continue to be analyzed.

Written by the indexing model from the issue text.

Description

Component: BinaryViewType Effort: Low File Format: PE Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 3.2
  • OS: macOS
  • OS Version: 12.4
  • CPU Architecture: M1

Bug Description:
On trying to analyze the binary in Vector35/binaryninja-api#3709, many functions are created for data variable symbols, because they are technically exports (and have an entry), but are in the text segment. These functions are erroneous and misleading.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open the binary from Vector35/binaryninja-api#3709
  2. Go to 0x100162e8
  3. Observe nonsense function created
  4. Undefine function
  5. Observe real data variable at that address

Expected Behavior:
I expected binja to not try to analyze a data variable

Screenshots:
image
image

Additional Information:
This is a bug in the PE loader observing that the segment of the export is executable, and assuming it can create a function there.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.