Tags and comments defined between the start of the basic block and the address of the first IL instruction are not rendered in the IL disasembly

Open
#3,754 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start by reproducing the case described: place a tag or comment at 0x140007fad, between the basic block start at 0x140007fab and the first IL instruction at 0x140007fb4. Trace the post-processing of disassembly text lines; done means tags and comments in that range are rendered in the IL disassembly.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Low UI: Graph UI: Linear

As we can see from the screenshot, I added a tag at address 0x140007fad. It is between the start of the (disassembly) basic block, 0x140007fab, and the start of the first IL instruction, 0x140007fb4.

Screenshot 2022-12-22 at 6 04 52 PM

The problem is caused by a specific bug in how we post-process disassembly text lines, i.e., that we only include any tags/comments starting from the address of the first IL instruction. Anything before that is not rendered.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.