Vector35 / Vector35/binaryninja-api

Change Type on data symbol does not auto populate entry

Open
#2,874 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low UI: Dialogs
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 3.0.3219-dev
  • OS: macOS
  • OS Version: 12.0.1

Bug Description:
When you press Y to change the type of a function, binja automatically fills in the function's type and name. However, if you press Y to change the type of a data variable, the entry will not be filled with the variable type and uses whatever was last in your history. Additionally, the "Type for variable" text does not have the name of the variable whose type you're changing. This feels like a regression, as I'm pretty sure this used to auto fill the selected variable's type.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open any binary
  2. Scroll to the imports / extern section
  3. Click any extern symbol
  4. Press Y
  5. Observe the type dialog does not contain the type of the symbol you selected

Expected Behavior:
I expected Change Type to autofill the type of the thing whose type I am changing

Screenshots:
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening an external symbol, selecting it, and pressing Y to open the Change Type dialog. Start at the Y action and the data-variable type dialog, then compare its behavior with function type changes; done means the selected variable's type and name populate the dialog instead of the previous history entry.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.