LinearView: cannot rename data variable without selecting its token

Open
#2,036 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Reproduce the behavior in LinearView with a line declaring a data variable, first selecting the whole line and pressing N, then selecting the variable name token and pressing N. Trace the rename handling for the N action and data-variable tokens; done means the whole selected line permits renaming the declared variable without requiring its name token to be highlighted.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Low UI: Linear

If I have a line in LinearView which declares a data variable, I cannot press N to rename it unless i specifically highlight the variable's name token. It would be much better if I could press N with the whole line selected and rename the variable.

Here's a visual indicator of the difference:

Cannot rename (no token selected):
image

Can rename (token selected):
image

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.