ViewFrame seems uninitialized when using UIContext.createTabForWidget
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with UIContext.createTabForWidget and trace how it creates a tab for an existing View such as LinearView or HexEditor. Reproduce the navigation-dialog crash in ViewFrame::getHistoryEntry and the graph-switch crash in ViewFrame::getTypeForView(QWidget*); done means these operations no longer crash for widgets added through this path.
Written by the indexing model from the issue text.
Description
Multiple ViewFrame methods crash Binary Ninja when creating a new tab for an existing View widget like LinearView and HexEditor. I've found at least two methods crash, there's probably more. The two I've found to crash are ViewFrame::getHistoryEntry and ViewFrame::getTypeForView(QWidget*).
The first one occurs whenever the user tries to use the navigation dialog (g) to change location. Scrolling and clicking around works fine, but as soon as the dialog is used, it crashes on ViewFrame::getHistoryEntry().
The second one occured with a LinearView when I accidentally pressed the space bar and it tried to switch to the Graph view. That one crashed on ViewFrame::getTypeForView(QWidget*).
I suspect that the ViewFrame is not being created or initialized, which is causing null derefs when its member fields are accessed.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Vector35/binaryninja-api
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Vector35/binaryninja-api#8540 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Vector35/binaryninja-api#8516 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Vector35/binaryninja-api#8503 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Vector35/binaryninja-api#8446 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Vector35/binaryninja-api#8444 ·
All issues in Vector35/binaryninja-api
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·