Many methods of abstract `did.database` implements specific SQL behavior

Open
#108 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
matlab, sql
Domain
databases

Research direction

Start with the abstract did.database methods named in the issue: run_sql_query, query_struct_to_sql_str, get_sql_query_str, and do_run_sql_query. Trace the other methods that call them to determine whether SQL-specific behavior is intentionally centralized or should be separated. Done means the project has a decided scope for an implementation-agnostic database abstraction and the affected callers are consistently covered.

Written by the indexing model from the issue text.

Description

  • run_sql_query
  • query_struct_to_sql_str
  • get_sql_query_str
  • do_run_sql_query (Abstract)

Also, many other methods call one or more of these methods. Is this intentional, or should we refactor the database class to be implementation-agnostic?

Dominant language
MATLAB
Stars
1
Forks
2
Avg merge
2h 18m
Merged PRs (30d)
39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from VH-Lab/DID-matlab

All issues in VH-Lab/DID-matlab

Similar issues

More MATLAB issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.