Toggling between Playground On/Off

Open
#32 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, unity
Domain
game-dev, tooling

Research direction

Reproduce the failure in Unity v2018.3.6f1 by toggling Playground On/Off repeatedly, then inspect Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs around lines 101, 112, and 115. Trace the obsolete PrefabUtility calls and confirm that repeated toggling completes without console errors or leaving the user unable to switch modes.

Written by the indexing model from the issue text.

Description

Hi Ciro :)
Using Unity v2018.3.6f1 and the current Unity Asset Store build of the Unity Playground, I find that some console errors are thrown after toggling between Playground On/Off a couple of times (first time is fine). As a consequence, the user is no longer able to toggle between these modes. The Console Log seems to indicate that the issue relates from syntax changes:

Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs(101,49): warning CS0618: UnityEditor.PrefabUtility.GetPrefabParent(UnityEngine.Object)' is obsolete: Use GetCorrespondingObjectFromSource.'

Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs(112,35): warning CS0618: UnityEditor.PrefabUtility.RevertPrefabInstance(UnityEngine.GameObject)' is obsolete: Use the overload that takes an InteractionMode parameter.'

Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs(115,91): warning CS0618: UnityEditor.PrefabUtility.GetPrefabParent(UnityEngine.Object)' is obsolete: Use GetCorrespondingObjectFromSource.'

Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs(115,157): warning CS0618: UnityEditor.ReplacePrefabOptions' is obsolete: This has turned into the more explicit APIs, SavePrefabAsset, SaveAsPrefabAsset, SaveAsPrefabAssetAndConnect'

Assets/INTERNAL/Scripts/Editor/DefaultComponents/GameObjectInspector.cs(115,35): warning CS0618: UnityEditor.PrefabUtility.ReplacePrefab(UnityEngine.GameObject, UnityEngine.Object, UnityEditor.ReplacePrefabOptions)' is obsolete: Use SaveAsPrefabAsset or SaveAsPrefabAssetAndConnect with a path instead.'

Cheers,
Jim

Dominant language
C#
Stars
974
Forks
161
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Unity-Technologies/UnityPlayground

All issues in Unity-Technologies/UnityPlayground

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.