`ui5 init` generates ui5.yaml with a wrong type: `type: library` instead of `type: application`

Open
#551 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
cli

Research direction

Start by reproducing the issue with a package.json containing "type": "module" and run ui5 init from the application root. Inspect the generated ui5.yaml and trace the ui5 init CLI entry point to find the type selection; done means the generated file contains type: application.

Written by the indexing model from the issue text.

Description

module/ui5-cli

When I run ui5 init, it generates ui5.yaml with a wrong type: type: library instead of type: application, although in package.json it's written "type": "module".

Expected Behavior

ui5.yaml should contain type: application

Current Behavior

ui5.yaml contains type: library

Steps to Reproduce the Issue

  1. Install ui5-tooling globally
  2. Go in console to the root of the app, where package.json is located
  3. Run ui5 init
  4. I got type: library

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 2.12.1
  • Node.js Version: v17.0.0-v8-canary202108258414d1aed8
  • npm Version: 7.21.1
  • OS/Platform: Windows 10 21H1 x64
  • Browser (if relevant): not relevant
  • Other information regarding your environment (optional): nothing
{...}
Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UI5/cli

All issues in UI5/cli

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.