UI5 / UI5/cli

Build cache: task filters pollute cache keys for unaffected projects

Open
#1,519 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module/ui5-project
Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Description

Expected Behavior

Filters that don't affect a project's effective task list should not change its cache key.

Current Behavior

--include-task / --exclude-task are baked verbatim into the build base signature
shared across every project in the graph. Filters irrelevant to a project (e.g. a task that
doesn't exist for that project type) still change its cache key, causing unnecessary rebuilds
when building the same project via different entry points.

Root cause

BuildContext computes _buildSignatureBase from the raw includedTasks/excludedTasks
arrays and passes it unchanged to every ProjectBuildContext. But composeTaskList only
applies a filter when the task exists in the project's allTasks — so two builds with
different but equally-irrelevant filters produce identical effective task lists yet different
cache keys.

Steps to Reproduce the Issue

  1. Build a root application with --include-task generateVersionInfo. Dependent libraries
    cache under a signature encoding includedTasks: ["generateVersionInfo"].
  2. generateVersionInfo doesn't exist for library projects — no effect on their builds.
  3. Build a library standalone (no flag). Signature now has includedTasks: [] → cache miss
    → full rebuild despite identical inputs and identical effective task list.

Fix direction

Move include/exclude contribution from getBaseSignature into the per-project signature
(getProjectSignature), keyed on the resolved output of composeTaskList rather than the
raw filter arrays.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 5.0.0-alpha.7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with BuildContext and ProjectBuildContext, following getBaseSignature, getProjectSignature, and composeTaskList. Verify how resolved task lists affect each project's cache signature, then test that irrelevant include or exclude filters produce the same key and avoid an unnecessary rebuild.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.