Dependency bundling ignores mvc factory functions
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- build-system, tooling
Research direction
Start with the dependency handling in ui5-builder and the related usage in TechnicalInfo.js at the referenced line. Reproduce the issue with the openui5-sample-app using ui5 build self-contained --all, then inspect the bundle and network trace. Done means resources referenced through MVC factory APIs such as sap.ui.fragment are included instead of loaded individually.
Written by the indexing model from the issue text.
Description
Expected Behavior
MVC factory APIs like sap.ui.fragment should be identified as dependency declarations.
Current Behavior
Resources referenced by MVC factories are not processed as bundle dependencies.
Steps to reproduce the issue
- Setup openui5-sample-app
- Add
sap.ui.layoutdependency for technical information dialog:npm install @openui5/sap.ui.layout - Execute
ui5 build self-contained --all - Serve
distdirectory - Open technical information dialog by pressing CTRL + SHIFT + ALT + P
- Observe in the network trace that single sap.ui.layout controls are being loaded.
➡️ This indicates that they are not part of the self contained bundle
CC: @codeworrior
Also see https://github.com/SAP/ui5-tooling/issues/68
Affected components
- Dominant language
- JavaScript
- Stars
- 511
- Forks
- 83
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/cli
-
module/ui5-builder
-
Build cache: buildThemes cache is invalidated by irrelevant library.js / .library content changes Openmodule/ui5-builder module/ui5-fs module/ui5-project
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
module/ui5-project
Difficulty 4/5 3-5 days Newbie friendliness 64/100
-
roadmap
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
babalae/bettergi-scripts-list#3674 ·
-
ecosystem wording
Difficulty 1/5 Under an hour Newbie friendliness 90/100
matrix-org/matrix.org#3649 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vadimdemedes/ink#1029 ·
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·