Forcefully add some classes (like sap/ui/core/ComponentSupport) to a self-contained build
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- build-system, tooling
Research direction
Start with the self-contained build behavior in ui5-builder and reproduce the issue using the sample app's index.html with data-sap-ui-oninit="module:sap/ui/core/ComponentSupport". Check how sap/ui/core/ComponentSupport is handled when generating sap-ui-custom.js. Done means the bootstrap contains the classes required by the application so no additional class files are loaded.
Written by the indexing model from the issue text.
Description
Expected Behavior
Only the sap-ui-custom.js boostrap JavaScript should be loaded when a self-contained build is chosen. The boostrap should contain all classes needed to run the application.
Current Behavior
Some files are anyways loaded seperately, such as the sap/ui/core/ComponentSupport in case the data-sap-ui-oninit boostrap option is chosen to load a component.
Steps to reproduce the issue
- Change the index.html file of the samle application to load the ComponentContainer via the data-sap-ui-oninit="module:sap/ui/core/ComponentSupport" method
- Build & serve the sample app self-contained
Context
- OS/Platform: Windows
- Node.js Version: 10.11.0
- npm Version: 6.4.1
- Browser (if relevant): Chrome Dev.
- Other information: Tested on 1.59.0
Affected components
- Dominant language
- JavaScript
- Stars
- 511
- Forks
- 83
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/cli
-
module/ui5-builder
-
Build cache: buildThemes cache is invalidated by irrelevant library.js / .library content changes Openmodule/ui5-builder module/ui5-fs module/ui5-project
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
module/ui5-project
Difficulty 4/5 3-5 days Newbie friendliness 64/100
-
roadmap
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
babalae/bettergi-scripts-list#3674 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vadimdemedes/ink#1029 ·
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·