themeBuilder includes all less files

Open
#374 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
build-system

Research direction

Reproduce the issue by building the sap_belize theme through themeBuilder in ui5-builder and inspect the overall build process that copies the Less files. Determine whether the intended result is to exclude Less files by default or enable source maps when they are retained. Done means the chosen behavior is implemented and verified with a theme build.

Written by the indexing model from the issue text.

Description

module/ui5-builder

Expected Behavior

When I build a new theme, I had expected all the CSS (generated files) but not (at least by default) the less files.
OR
If the less files are intentionally allowed to be part of the build, then I would have expected source mapping to be enabled.

Current Behavior

All files (this includes less files) are copied over. I imagine its nothing to do with the themeBuilder task itself, but rather part of the over all build process.

Steps to reproduce the issue

  1. build any theme (e.g. sap_belize)

Context

  • UI5 Module Version 1.1.0

Affected components (if known)

Log Output / Stack Trace

{...}
Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UI5/cli

All issues in UI5/cli

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.