fs.DuplexCollection byGlob returns wrong result
@RandomByte is already working on this.
Since Nov 22, 2019.
Assessment
This issue has not been assessed yet.
Description
Hello guys,
I created a small sample, using the ui5-tooling with simple configuration and custom task.
I tried to exclude all files from processing, except for two types of files (.lit.js and .hbs), look at the ui5.yaml.
But, this seems to cause an issue in my custom task, when I try to execute
workspace.byGlob("/resources/*.hbs") - it matches not only .hbs files, but the .lit.js files as well.
Expected Behavior
workspace.byGlob("/resources/*.hbs") to match .hbs files only.
Current Behavior
workspace.byGlob("/resources/*.hbs") matches not just .hbs files, but .lit.js as well.
Steps to reproduce the issue
- Clone repository https://github.com/ilhan007/ui5-tooling-customtask-sample
- Run
npm installin the root - Run
npm run build - Explore the build log - the result from
workspace.byGlob("/resources/*.hbs")is logged and you can see that it finds not just.hbsfiles. Or, You can add debugger in the task at this line:https://github.com/ilhan007/ui5-tooling-customtask-sample/blob/master/lib/task.js#L5
Context
- UI5 Module Version (output of
ui5 --versionwhen using the CLI):1.12.1 - Node.js Version:
12.13.0 - npm Version:
6.12 - OS/Platform:
macOS 10.15 Catalina
Affected components (if known)
- Dominant language
- JavaScript
- Stars
- 511
- Forks
- 83
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/cli
-
module/ui5-builder
-
Build cache: buildThemes cache is invalidated by irrelevant library.js / .library content changes Openmodule/ui5-builder module/ui5-fs module/ui5-project
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
module/ui5-project
Difficulty 4/5 3-5 days Newbie friendliness 64/100
-
roadmap
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
babalae/bettergi-scripts-list#3674 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vadimdemedes/ink#1029 ·
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·