CSS files are not bundled for self-contained build (multiple CSS files are loaded for each library)

Open
#359 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, node.js
Domain
build-system

Research direction

Start with the ui5-builder component and reproduce the self-contained sample app build from the issue. Inspect the browser network trace to identify why separate per-library CSS files are emitted; done means the selected theme is served as one CSS file for the whole self-contained build.

Written by the indexing model from the issue text.

Description

module/ui5-builder

Expected Behavior

One CSS file for the whole self-contained build should be loaded, based on the theme selected.

Current Behavior

Multiple CSS files (per library) are loaded separately by the browser, causing some performance degragation.

Steps to reproduce the issue

  1. Build & serve the sample app self-contained
  2. Check network trace to see, that more than one CSS file is loaded

Context

  • OS/Platform: Windows
  • Node.js Version: 10.11.0
  • npm Version: 6.4.1
  • Browser (if relevant): Chrome Dev.
  • Other information: Tested on 1.59.0

Affected components

Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UI5/cli

All issues in UI5/cli

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.