Files imported by UniversalDate missing from self-contained build output
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- build-system, tooling
Research direction
Start with the linked openui5 UniversalDate.js source at line 90 and inspect how ui5-builder creates sap-ui-custom.js from dynamically loaded modules. Reproduce the self-contained build using the listed UniversalDate calendar files, then verify that the Buddhist, Gregorian, Islamic, Japanese, and Persian modules are included without missing imports.
Written by the indexing model from the issue text.
Description
Expected Behavior
There are no missing JavaScript files in sap-ui-custom.js used by an application.
Current Behavior
sap/ui/core/date/(Buddhist|Gregorian|Islamic|Japanese|Persian).js is not being included.
Steps to reproduce the issue
-
Take a look at the sap/ui/core/date/UniversalDate.js source from the openui5 repo:
https://github.com/SAP/openui5/blob/6478939c8d4a89b3197647d6bcb99e3cb54f3047/src/sap.ui.core/src/sap/ui/core/date/UniversalDate.js#L90 -
There is a sap.ui.requireSync call on line 90 that loads a computed filepath:
sap.ui.requireSync("sap/ui/core/date/" + sCalendarType) -
Due to the dynamic nature of this import, the build of sap-ui-custom.js won't include any of the possible files. I'm not sure if a fix would go into the build tools or into the SDK source code...
Context
- UI5 Module Version (output of
ui5 --versionwhen using the CLI):1.5.2 (from C:\dev\master\htmlcommons-samples\openui-microbump\node_modules\@ui5\cli\bin\ui5.js) - Node.js Version:
v8.11.1 - npm Version:
6.9.0 - OS/Platform:
Windows 10 1809 - Browser (if relevant):
N/A - Other information:
N/A
Affected components (if known)
Log Output / Stack Trace
N/A
- Dominant language
- JavaScript
- Stars
- 511
- Forks
- 83
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/cli
-
module/ui5-builder
-
Build cache: buildThemes cache is invalidated by irrelevant library.js / .library content changes Openmodule/ui5-builder module/ui5-fs module/ui5-project
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
module/ui5-project
Difficulty 4/5 3-5 days Newbie friendliness 64/100
-
roadmap
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
babalae/bettergi-scripts-list#3674 ·
-
ecosystem wording
Difficulty 1/5 Under an hour Newbie friendliness 90/100
matrix-org/matrix.org#3649 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vadimdemedes/ink#1029 ·
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·