Undirected calls to `'Brochodilator_and_Steroids'` in `ALRI` module

Open
#1,172 0 comments 0 reactions 3 assignees View on GitHub

@inesll is already working on this.

Since Nov 3, 2023.

Assessment

This issue has not been assessed yet.

Description

epi good-for-new-starter

Joe notes that the consumable 'Brochodilator_and_Steroids' defined in ALRI:

https://github.com/UCL/TLOmodel/blob/7c152da4756a9d08ba244c7cc868eb1de0f0e8eb/src/tlo/methods/alri.py#L2734

is never defined.

But it looks like it's never called, because it it were an error would be thrown in line 2400 when we try to access it.

https://github.com/UCL/TLOmodel/blob/7c152da4756a9d08ba244c7cc868eb1de0f0e8eb/src/tlo/methods/alri.py#L2394

So, two things to think about:

  1. Why is it never called and should it be? (This check instead occurs only ever at '1a'...?)
  2. What should the consumables definition be? (Should it be just self._get_cons('Inhaled_Brochodilator') as at '1a'?
Dominant language
Python
Stars
35
Forks
17
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/TLOmodel

All issues in UCL/TLOmodel

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.