remove ForwardProjectorByBinUsingRayTracing

Open
#643 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Start by searching the repository for ForwardProjectorByBinUsingRayTracing and any explicit selection paths. Check whether tests or configuration references remain, and compare the ray-tracing matrix path as needed; done means the obsolete implementation and its references are removed without affecting the replacement behavior.

Written by the indexing model from the issue text.

Description

This code very old and is superseded by the ray-tracing matrix. It should (and did) produce the same results, but was doing every calculation on-the-fly, with hard-coded symmetry calculations. it is therefore hard to maintain. This will create problems for instance in #618.

As far as I know, it is not used anywhere, except when the user asks for it explicitly. It might even no longer be tested.

Best to remove it therefore.

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/STIR

All issues in UCL/STIR

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.