Travis: test build with BUILD_EXECUTABLES=OFF

Open
#517 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, shell
Domain
build-system, ci-cd, testing-qa

Research direction

Start with .travis.yml and inspect its script section, then review the existing ctest and recon_test_pack/run_test_simulate_and_recon.sh checks. The change is done when those executable-dependent checks are skipped for BUILD_EXECUTABLES=OFF while the Python tests still run and CI exit status remains correct.

Written by the indexing model from the issue text.

Description

Anyone knows how to modify .travis.yml to do the recon_test_pack checks only when executables are build? Could be something like

script:
- |
   if ! [[ $EXTRA_BUILD_FLAGS == *"BUILD_EXECUTABLES=OFF"* ]]; then
      ctest --output-on-failure
      export PATH=$PATH:$TRAVIS_BUILD_DIR/install/bin
     cd $TRAVIS_BUILD_DIR/recon_test_pack
     ./run_test_simulate_and_recon.sh
     ...
  fi
 # Run Python tests, making sure we're using the correct Python interpreter
  ...

but I'm not sure what it will do for exit status will be etc. Could also use ( set -ev ...). not sure what is best. @casperdcl ?

Originally posted by @KrisThielemans in https://github.com/UCL/STIR/pull/516#issuecomment-618637845

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/STIR

All issues in UCL/STIR

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.