Writing subset sensitivities to file

Open
#215 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start at PoissonLogLikelihoodWithLinearKineticModelAndDynamicProjectionData, where each frame's subset sensitivity is written using names such as subset_sensitivity_0.hv. Trace the sensitivity-writing path and decide whether frame and subset identifiers are needed in filenames or only the final parametric product should be saved; done means successive frames no longer overwrite an unintended file.

Written by the indexing model from the issue text.

Description

In PoissonLogLikelihoodWithLinearKineticModelAndDynamicProjectionData, the sensitivity of each frame is calculated one after another. At the end of setting up each frame, the subset sensitivity is saved as, for example, subset_sensitivity_0.hv (for 0th subset).

This means that, for a given subset, each frame overwrites the previous one. We could save it as subset_sensitivity_f%_s%.hv for frames and subsets.

Alternatively, since we don't really need these subsets (we need the parametric versions, which are only calculated once all the individual frames have been calculated), we could just not write the sensitivity files for each frame as we calculate them, and only save the final product.

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/STIR

All issues in UCL/STIR

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.