`BinNormalisationFromECAT8::read_norm_data` prepends path to full path

Open
#1,601 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
data

Research direction

Open src/recon_buildblock/BinNormalisationFromECAT8.cxx around lines 238-242 and trace how norm_parser.data_file_name is formed. Reproduce the case where the data is outside the current directory; done means the full path is preserved without prepending the directory path again.

Written by the indexing model from the issue text.

Description

The following code prepends the directory path to the full path resulting in wrong paths if the data is not in the current directory, i.e. the norm_parser.data_file_name doesn't do what's expected.

https://github.com/UCL/STIR/blob/ff3d5ab170c22c42b834c0a951705c21a650fb66/src/recon_buildblock/BinNormalisationFromECAT8.cxx#L238-L242

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/STIR

All issues in UCL/STIR

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.