Add get_non_tof_ProjData to ProjData

Open
#1,322 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
data

Research direction

Start by reviewing the discussion in issues #1321 and #1320, then inspect the SSRB implementation in src/buildblock/SSRB.cxx around lines 44-55. Clarify whether the conversion belongs in ProjData or SSRB and how TOF compression should be handled. Done requires an agreed design and corresponding implementation scope.

Written by the indexing model from the issue text.

Description

question

This is more of a discussion point than an issue. That was first mentioned here: #1321 https://github.com/UCL/STIR/issues/1320#issuecomment-1887955732 w.r.t accessing non-TOF sinograms/viewgrams from TOF data without having to load each TOF sinogram/viewgram into python.

However, this should be generalized. It might be useful to add this conversion from TOF ProjData to non-TOF ProjData in the Projdata class.

Alternatively, it could be implemented into SSRB. But SSRB does not currently support TOF compression.

https://github.com/UCL/STIR/blob/151c457495721d38e1c3f00780a81055735bacb3/src/buildblock/SSRB.cxx#L44-L55

@KrisThielemans @NikEfth @NicoleJurjew thoughts?

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from UCL/STIR

All issues in UCL/STIR

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.