TrinityCore / TrinityCore/WowPacketParser

System.ArgumentOutOfRangeException - SMSG_UPDATE_OBJECT (3.4.2.50063)

Open
#802 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
522
Forks
387
Avg merge
3d 6h
Merged PRs (30d)
4

Description

System.ArgumentOutOfRangeException
Index and length must refer to a location within the string. (Parameter 'length')
   at System.String.ThrowSubstringArgumentOutOfRange(Int32 startIndex, Int32 length)
   at System.String.Substring(Int32 startIndex, Int32 length)
   at WowPacketParser.Misc.Packet.FormatFloat(Single value) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Misc\PacketReads.cs:line 742
   at WowPacketParser.Misc.Packet.ReadSingle(String name, Object[] indexes) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Misc\PacketReads.cs:line 362
   at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.ReadMovementUpdateBlock(Packet packet, WowGuid guid, WoWObject obj, Object index) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 436
   at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.ReadCreateObjectBlock(Packet packet, CreateObject createObject, WowGuid guid, UInt32 map, CreateObjectType createType, Object index) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 175
   at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.HandleUpdateObject(Packet packet) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 150
   at WowPacketParser.Parsing.Handler.Parse(Packet packet, Boolean isMultiple) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Parsing\Handler.cs:line 149

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with WowPacketParser/Misc/PacketReads.cs at FormatFloat, then trace the ReadSingle call from WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs in ReadMovementUpdateBlock. Reproduce the SMSG_UPDATE_OBJECT failure for client version 3.4.2.50063 and determine how the reported substring bounds should be handled; done means the packet parses without this exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
reverse-engineering, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.