TrinityCore / TrinityCore/TrinityCoreCustomChanges
PvP Ranks extra honor
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 83
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
PvP Ranks calls
honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f);
but then
honor = int32(honor_f);
so the custom extra honor gets lost.
honor_f should probably be changed instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the C++ sources for the PvP Ranks calculation shown in the issue and compare it with commit c840b87d24ba21f1c06127f0d2ce991afe0de7b2. Trace how the extra-honor rate flows into honor_f and the final integer value, then verify that PvP rank honor retains the custom adjustment without changing unrelated behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100